Fix flaky Kestrel Http/2 Stream tests #59820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
area-networking
BrennanConroy
requested review from
JamesNK,
halter73 and
mgravell
as code owners
JamesNK
reviewed
Jan 13, 2025
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
Show resolved
Hide resolved
JamesNK
approved these changes
Jan 13, 2025
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use inline pipe scheduling which means the
StartStreamAsynccall will call continuations inline which will add the stream to the connection before returning. However, inline continuations relies on a continuation actually being present. So all these tests relied on a race condition where we had an activepipeReader.ReadAsynccall in order to call the continuation inline. If you add a delay or pause the thread right before theReadAsyncinHttp2Connection.csthen you can force the race and cause_connection._streams[1];to fail as there is no stream present yet.The fix is to make sure the stream is present, and we attain that by making sure the app code is running which is after the stream has been created.